Skip to content

Comments

SettingsToggle: icon → icon_name#107

Merged
danirabbit merged 1 commit intomainfrom
danirabbit/settingstoggle-iconname
Apr 24, 2025
Merged

SettingsToggle: icon → icon_name#107
danirabbit merged 1 commit intomainfrom
danirabbit/settingstoggle-iconname

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Apr 23, 2025

in GTK4 ToggleButton has a nice icon_name property we can bind to, so this just makes things much easier. Made it a settable property instead of construct to future proof for a world where this widget might be created by a model that recycles widgets

@danirabbit danirabbit requested a review from a team April 23, 2025 22:49
@danirabbit danirabbit moved this to Needs Review in GTK4 Porting Apr 23, 2025
@danirabbit danirabbit merged commit 682d0c6 into main Apr 24, 2025
4 checks passed
@danirabbit danirabbit deleted the danirabbit/settingstoggle-iconname branch April 24, 2025 03:54
@github-project-automation github-project-automation bot moved this from Needs Review to Done in GTK4 Porting Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants