Skip to content

CheckView: invert VM warning for Apple Mseries #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
danirabbit wants to merge 1 commit into
base: main
Choose a base branch
from
+34 −15
Draft

CheckView: invert VM warning for Apple Mseries #923

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 34 additions & 15 deletions src/Views/CheckView.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,12 @@ public class Installer.CheckView : AbstractInstallerView {
"applications-development"
);

var mseries_view = new CheckView (
_("Limited Hardware Support"),
_("Installing in a virtual machine is recommended for Apple M-series devices."),
"computer-fail"
);

var vm_view = new CheckView (
_("Virtual Machine"),
_("Some parts of %s may run slowly, freeze, or not function properly.").printf (Utils.get_pretty_name ()),
Expand Down Expand Up @@ -113,8 +119,20 @@ public class Installer.CheckView : AbstractInstallerView {
critical ("Couldn't read apt sources: %s", e.message);
}

if (get_vm () || Installer.App.test_mode) {
message_box.append (vm_view);
try {
bool is_vm;
bool is_mseries;
get_cpu_info (out is_vm, out is_mseries);

if ((is_mseries && !is_vm) || Installer.App.test_mode) {
message_box.append (mseries_view);
}

if ((is_vm && !is_mseries) || Installer.App.test_mode) {
message_box.append (vm_view);
}
} catch (Error e) {
critical (e.message);
}

if (!minimum_specs || Installer.App.test_mode) {
Expand Down Expand Up @@ -158,21 +176,22 @@ public class Installer.CheckView : AbstractInstallerView {
return 0;
}

private static bool get_vm () {
File file = File.new_for_path ("/proc/cpuinfo");
try {
DataInputStream dis = new DataInputStream (file.read ());
string? line;
while ((line = dis.read_line (null, null)) != null) {
if (line.has_prefix ("flags") && line.contains ("hypervisor")) {
return true;
}
private void get_cpu_info (out bool is_vm, out bool is_mseries) throws Error {
is_mseries = false;
is_vm = false;

var file = File.new_for_path ("/proc/cpuinfo");
var dis = new DataInputStream (file.read ());
string? line;
while ((line = dis.read_line (null, null)) != null) {
if (line.has_prefix ("vendor_id") && line.contains ("Apple")) {
is_mseries = true;
}
} catch (Error e) {
critical (e.message);
}

return false;
if (line.has_prefix ("flags") && line.contains ("hypervisor")) {
is_vm = true;
}
}
}

private class CheckView : Gtk.Grid {
Expand Down