Draft: check ESP size in bytes not sectors#911
Draft
tamara-schmitz wants to merge 2 commits intoelementary:mainfrom
Draft
Draft: check ESP size in bytes not sectors#911tamara-schmitz wants to merge 2 commits intoelementary:mainfrom
tamara-schmitz wants to merge 2 commits intoelementary:mainfrom
Conversation
Partially a necessary fix for elementary#448 and elementary#644. Also a continuation of PR elementary#621 which mostly does not apply anymore four years later except for the ESP check.
Member
|
@vjr would you be able to review this? :) |
Member
The diff LGTM but would be nice if someone can re-test , and if the following note might help: #621 (comment) edit: the workflows builds seem to be failing with an "unused var" error too. |
Author
Oh neat that is indeed helpful. Did you set up a build environment within that VM or is there a reasonable well to set up a dev env on a non-ElementaryOS system? Building in a VM is probably easier for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially a necessary fix for #448 and #644.
Also a continuation of PR #621 which mostly does not apply anymore four years later except for the ESP check.
So far this patch merely fixes the ESP partition size check triggered in the PartitionView when doing a custom installation with custom partitioning.
I am marking this as a draft as I was unable to build this patch so far. That is in progress.