Skip to content

Fix erase and install failure when lvm already exists #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vjr wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Fix erase and install failure when lvm already exists #681

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b07b23b
Commit distinst disk mklabel changes before further default install
vjr Jan 26, 2023
e28cb17
Merge branch 'master' into fix-erase-and-install-over-existing-lvm
vjr Jan 26, 2023
20b9ddf
Comment out initial attempt at a fix
vjr Jan 26, 2023
50f5e95
Alternate attempt at a fix - remove existing partitions before prepar…
vjr Jan 26, 2023
c199a8c
Merge branch 'master' into fix-erase-and-install-over-existing-lvm
vjr Feb 15, 2023
1273c9e
Merge branch 'master' into fix-erase-and-install-over-existing-lvm
vjr Nov 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions daemon/Daemon.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,13 +305,26 @@ public class InstallerDaemon.Daemon : GLib.Object {
value = 0
};

unowned var partitions = disk.list_partitions ();
foreach (unowned var partition in partitions) {
disk.remove_partition (partition.get_number ());
}

// Prepares a new partition table.
int result = disk.mklabel (bootloader);

if (result != 0) {
throw new GLib.IOError.FAILED ("Unable to write partition table to %s", disk_path);
}

// Commit the new partition table.
/*
result = disk.commit ();

if (result != 0) {
throw new GLib.IOError.FAILED ("Unable to commit partition table to %s", disk_path);
}*/

var start = disk.get_sector (ref start_sector);
var end = disk.get_sector (ref boot_sector);

Expand Down