Do not try to fallback to x11 session when it is unavailable#824
Merged
danirabbit merged 2 commits intomainfrom Sep 14, 2025
Merged
Do not try to fallback to x11 session when it is unavailable#824danirabbit merged 2 commits intomainfrom
danirabbit merged 2 commits intomainfrom
Conversation
Member
bobby285271
commented
Sep 14, 2025
bobby285271
commented
- Motivation: gnome-session 49 disabled x11 support by default session-settings#91
Motivation: elementary/session-settings issue 91.
danirabbit
reviewed
Sep 14, 2025
src/Application.vala
Outdated
| return; | ||
| } | ||
|
|
||
| if (!has_pantheon_x11_session) { |
Member
There was a problem hiding this comment.
We could probably avoid connecting this signal altogether tbh. Or at least have this as the first return condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.