Introduce and use GestureTrigger #2757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leolost2605
force-pushed
the
leolost/gesture-trigger
branch
from
ad2f1cc to
5964fa2
Compare
GestureTrigger provides a configurable way to specify what should trigger a gesture. It also automatically enables the correct backends needed to recognize the handled gestures. Currently two triggers are provided. SwipeTrigger recognizing swipes on a provided actor and GlobalTrigger recognizing global touch gestures.
leolost2605
force-pushed
the
leolost/gesture-trigger
branch
from
5964fa2 to
f07903e
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GestureTrigger provides a configurable way to specify what should trigger a gesture. It also automatically enables the correct backends needed to recognize the handled gestures. Currently two triggers are provided. SwipeTrigger recognizing swipes on a provided actor and GlobalTrigger recognizing global touch gestures.
This makes it easier for users of gesturecontroller by being declarative instead of imperative. They can now simply specify what gesture should be recognized and not how it is recognized.
It also moves very global gesture specific stuff from the gesturecontroller to the globaltrigger.
It also allows more flexibility which allows us to remove a workaround where we always allow gestures from the scroll backend and will provide more freedom in the future (e.g. allowing gestures to only start within a certain area e.g. for dock swipe up).