WindowManager: handle multiple modal proxies with grabs #2738
+24
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenemter
force-pushed
the
lenemter/better-modal-proxy
branch
from
14d207a to
61366a2
Compare
lenemter
force-pushed
the
lenemter/better-modal-proxy
branch
from
61366a2 to
52cc456
Compare
leolost2605
reviewed
Jan 22, 2026
| var proxy = new ModalProxy (); | ||
| var current_proxy = modal_stack.peek_head (); | ||
| if (current_proxy.grab != null) { | ||
| current_proxy.grab.dismiss (); |
Member
There was a problem hiding this comment.
Hmm IIRC clutter stacks the grabs internally already so why is this needed?
Member
Author
There was a problem hiding this comment.
Hmmm... It was a bit broken when I tested it on older mutter but now it works fine. Thanks for letting me know!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to correctly handle multiple modal proxies with grabs (e.g. window overview + area screenshot)