Fix highlighting after reselection of same word#1484
Fix highlighting after reselection of same word#1484
Conversation
* Sync with GitManager and ProjectChooserButton
|
@zeebok You may like to take a look at this and let me know if by any chance it also fixes the crashing problem we discussed. |
zeebok
left a comment
zeebok
left a comment
There was a problem hiding this comment.
This works as expected though it seems slightly slower, particularly with removing the highlight after clicking elsewhere. Not sure if there is a way to fix that before merging but I think it could also be a separate PR if you wanted
|
@zeebok I see what you mean. I have now separated the throttle for the selection change signal so that can be faster. Could you reproduce the crash on |
jeremypw
dismissed
zeebok’s stale review
Significant changes made since review
Increase maximum length of selection for highlighting
…rtup Jeremypw/sync activeproject startup
jeremypw
force-pushed
the
jeremypw/rework-highlight-selection
branch
from
6816410 to
2a7161d
Compare
|
@jeremypw I will try to take a look at this review again this week! |
|
Converting to draft as there seems to be some code from the dogfood fork accidentally merged here! |
2 participants
Fixes #1483
Throttling the update-spaces function was tried but the resulting lag was found to be distracting so now they are updated straight-away as before. This is inefficient but any improvement can be left for another PR.