Skip to content

SourceDialog: use Gtk.ComboboxText #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danirabbit merged 3 commits into from
Jan 28, 2026
Merged

SourceDialog: use Gtk.ComboboxText #899

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d3eb14
SourceDialog: use Gtk.ComboboxText
danirabbit Jan 27, 2026
be3d71e
Merge branch 'master' into danirabbit/sourcedialog-comboboxtext
danirabbit Jan 28, 2026
980ca3f
Merge branch 'master' into danirabbit/sourcedialog-comboboxtext
danirabbit Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions src/SourceDialog/SourceDialog.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public class Maya.View.SourceDialog : Granite.Dialog {
private Gee.Collection<PlacementWidget> backend_widgets;
private Gee.HashMap<string, bool> widgets_checked;
private Gtk.Button create_button;
private Gtk.ComboBox type_combobox;
private Gtk.ComboBoxText type_combobox;
private Gtk.ListStore list_store;
private Gtk.CheckButton is_default_check;
private E.Source source = null;
Expand Down Expand Up @@ -75,12 +75,10 @@ public class Maya.View.SourceDialog : Granite.Dialog {

list_store = new Gtk.ListStore (2, typeof (string), typeof (Backend));

var renderer = new Gtk.CellRendererText ();

type_combobox = new Gtk.ComboBox.with_model (list_store);
type_combobox.hexpand = true;
type_combobox.pack_start (renderer, true);
type_combobox.add_attribute (renderer, "text", 0);
type_combobox = new Gtk.ComboBoxText () {
hexpand = true,
model = list_store
};

type_combobox.changed.connect (() => {
GLib.Value backend;
Expand Down