RepeatPanel: iterate without get_children #896
Merged
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardo-lemos
requested changes
Jan 28, 2026
| } | ||
|
|
||
| foreach (var child in exceptions_list.get_children ()) { | ||
| if (child is ExceptionGrid == false) |
Collaborator
There was a problem hiding this comment.
Is it safe to remove the type checking? Could there be cases where the row is not an ExceptionGrid?
Member
Author
There was a problem hiding this comment.
Yes we had type checking before because get children includes headers. Row by index only returns rows, so they will always be the correct type
leonardo-lemos
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't use
get_childrenin GTK4.get_row_at_indexskips headers so we don't need to type check