EventButton: don't subclass Revealer #854
Conversation
danirabbit
commented
Jul 23, 2025
danirabbit
commented
- Bump copyright header
- Revealer is sealed in GTK4, so don't subclass revealer
- Move hide/show functions internally so we don't have to make the revealer publicly accessible
- Minor code style while we're here
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
The hide/reveal mechanism does not work correctly. The events hide but do not re-appear when space is available.
|
@jeremypw can you let me know how to reproduce the issue? I was testing by enabling and disabling calendars |
|
@danirabbit I was testing by resizing the calendar window. In master the event buttons are replaced by a placeholder below a certain size and re-appear on enlarging the window again. In this PR the buttons disappear but do not reappear unless the calendar is scrolled to another month and back. |
|
@jeremypw ah I misunderstood what this was for. Thank you! It should be fixed now |
There was a problem hiding this comment.
Latest commits fix the reveal issue previously mentioned.
I found another issue where appearance differs from main. If you add a second event to a day where where there is only just room to display one event you get overlapping text:
In main the event is replaced by "2 more..."
|
@jeremypw sorry for taking forever to follow up! Should be fixed now |
|
@jeremypw can I get a re-review please :) |
|
Sorry, I missed the re-review request. I'll get onto it. |
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
Everything good now afaict. There was an issue deleting events but that also occured in master and seems unrelated to these changes.
4 participants
