Update Flathub search URL to new format with locale support#2377
Open
srueegger wants to merge 1 commit intoelementary:mainfrom
Open
Update Flathub search URL to new format with locale support#2377srueegger wants to merge 1 commit intoelementary:mainfrom
srueegger wants to merge 1 commit intoelementary:mainfrom
Conversation
The Flathub website has been redesigned with a new URL structure for search. This updates the dynamic search link to use the new format: https://flathub.org/{locale}/apps/search?q={query} The system locale is automatically detected and the language code is extracted (e.g., "de" from "de_DE.UTF-8") to provide localized search results. Falls back to "en" if locale cannot be determined.
Member
|
What if we do when the system locale isn't available on Flathub website? 🤔 |
Contributor
Author
|
@ryonakano That's a good question that I hadn't thought of. Currently, you also get an Error 404 if the language is not available on Flathub. I see two possible solutions:
We can create a config file with the languages and use an if query to check whether the OS language matches one of the languages – if so, everything is fine; if not, simply fall back to English.
Do you see any other options, and which solution would you prefer? |
Member
|
We could open a feature request to the flathub website to handle this for us 🤷♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Flathub website has been redesigned with a new URL structure for search. This updates the dynamic search link to use the new format: https://flathub.org/{locale}/apps/search?q={query}
The system locale is automatically detected and the language code is extracted (e.g., "de" from "de_DE.UTF-8") to provide localized search results. Falls back to "en" if locale cannot be determined.