Skip to content

Package: Remove some unused methods and signals #2366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leolost2605 merged 1 commit into from
Oct 12, 2025
+0 −20
Merged

Package: Remove some unused methods and signals #2366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions src/Core/Package.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,6 @@ public class AppCenterCore.Package : Object {
"language-discrimination"
};

public signal void changing (bool is_changing);
/**
* This signal is likely to be fired from a non-main thread. Ensure any UI
* logic driven from this runs on the GTK thread
*/
public signal void info_changed (ChangeInformation.Status status);

public enum State {
NOT_INSTALLED,
INSTALLED,
Expand Down Expand Up @@ -424,7 +417,6 @@ public class AppCenterCore.Package : Object {

construct {
change_information = new ChangeInformation ();
change_information.status_changed.connect (() => info_changed (change_information.status));

action_cancellable = new GLib.Cancellable ();
}
Expand Down Expand Up @@ -546,8 +538,6 @@ public class AppCenterCore.Package : Object {
}

private void prepare_package_operation (State initial_state) {
changing (true);

action_cancellable.reset ();
change_information.start ();
state = initial_state;
Expand Down Expand Up @@ -583,8 +573,6 @@ public class AppCenterCore.Package : Object {
}

private void clean_up_package_operation (bool success, State success_state, State fail_state) {
changing (false);

if (success) {
change_information.complete ();
state = success_state;
Expand Down Expand Up @@ -621,10 +609,6 @@ public class AppCenterCore.Package : Object {
return cached_search_score;
}

public void set_name (string? new_name) {
_name = Utils.unescape_markup (new_name);
}

public string? get_description () {
if (description == null) {
description = component.get_description ();
Expand Down Expand Up @@ -661,10 +645,6 @@ public class AppCenterCore.Package : Object {
return summary;
}

public void set_summary (string? new_summary) {
summary = new_summary;
}

public string get_progress_description () {
return change_information.status_description;
}
Expand Down