-
-
Notifications
You must be signed in to change notification settings - Fork 105
Introduce a show package action #2361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
89a84a6 to
48f2cd9
Compare
danirabbit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YES! Thank you so much for doing this. I've been meaning to get to it and just haven't.
I only have one minor nitpick about connecting to click released instead of pressed
48f2cd9 to
8752b0a
Compare
|
@danirabbit updated it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go! Nice work :)
Introduce and use a show package action instead of long signal chains.
The first commit introduces the action and required infrastructure, i.e. a uid property for the packages.
The following commits start to use the action instead of signals.
Use rebase to merge.