Skip to content

Fix ref cycle #2192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
leolost2605 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix ref cycle #2192

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73a6e1b
Fix ref cycle
leolost2605 Jun 21, 2024
dcf6345
Merge branch 'main' into leolost/appinfoview-fix-ref-cycle
leolost2605 Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/Views/AppInfoView.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ public class AppCenter.Views.AppInfoView : Adw.NavigationPage {
screenshot_cache = new AppCenterCore.ScreenshotCache ();
}

~AppInfoView () {
warning ("DESTROYED");
}

construct {
AppCenterCore.FlatpakBackend.get_default ().cache_flush_needed.connect (() => {
to_recycle = true;
Expand Down Expand Up @@ -579,13 +583,13 @@ public class AppCenter.Views.AppInfoView : Adw.NavigationPage {
screenshot_overlay.add_controller (screenshot_motion_controller);

screenshot_motion_controller.enter.connect (() => {
screenshot_arrow_revealer_n.reveal_child = true;
screenshot_arrow_revealer_p.reveal_child = true;
// screenshot_arrow_revealer_n.reveal_child = true;
// screenshot_arrow_revealer_p.reveal_child = true;
});

screenshot_motion_controller.leave.connect (() => {
screenshot_arrow_revealer_n.reveal_child = false;
screenshot_arrow_revealer_p.reveal_child = false;
// screenshot_arrow_revealer_n.reveal_child = false;
// screenshot_arrow_revealer_p.reveal_child = false;
});

var app_screenshot_spinner = new Gtk.Spinner () {
Expand Down Expand Up @@ -760,7 +764,7 @@ public class AppCenter.Views.AppInfoView : Adw.NavigationPage {
on_package_state_changed ();

scrolled.vadjustment.value_changed.connect (() => {
title_revealer.reveal_child = scrolled.vadjustment.value > header.get_height ();
// title_revealer.reveal_child = scrolled.vadjustment.value > header.get_height ();
});

if (oars_flowbox.get_first_child () != null) {
Expand Down