Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

com.github.juarezfranco.tarefas-desktop 1.1.1 #398

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

juarezfranco
Copy link

@juarezfranco juarezfranco commented Aug 13, 2022

Review Checklist

  • App opens
  • Does what it says
  • Categories match

AppData

  • Name is unique and non-confusing
  • Matches description
  • Matches screenshot
  • Launchable tag with matching ID
  • Release tag with matching version and YYYY-MM-DD date
  • Custom colors meet WCAG A contrast or greater
  • OARS info matches

Flatpak

  • Uses elementary runtime
  • Sandbox permissions are reasonable

@juarezfranco juarezfranco requested a review from a team as a code owner August 13, 2022 18:56
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for your submission! There's a few things that need changing before we can publish your app in AppCenter:

  • Your app's name is the same as a default app, which is potentially confusing. Your app's name should be a unique brand name and not a generic name.
  • Your screenshot looks like it was taken on an older version of elementary OS. You'll want to update your screenshot to show your app running on the latest stable release, which is currently 6.1
  • Your appdata is missing a release tag for version 1.1.1

Some other recommendations, but not required:

  • Your app is currently targeting elementary flatpak platform 6.1 which is okay, but 7.0 is available so I would recommend updating to that
  • Your custom colors meet WCAG A level contrast which is the bare minimum, but I would recommend trying to meet WCAG AA so that your app listing will be legible to the most amount of people
  • I would recommend using the Office category instead of Utility in your .desktop file so that it will be easier for people to discover your app in AppCenter
  • Instead of a manual light and dark switch, I would recommend making use of system dark style preference, which is documented here: https://docs.elementary.io/develop/apis/color-scheme#setting-a-dark-style

Thanks again and let me know if you have any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants