-
Notifications
You must be signed in to change notification settings - Fork 240
Add support for linking new devices in the QRCodeLoginScreen. #4891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger Swift against 20505d2 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #4891 +/- ##
===========================================
- Coverage 79.54% 79.41% -0.14%
===========================================
Files 892 892
Lines 65040 65319 +279
===========================================
+ Hits 51739 51870 +131
- Misses 13301 13449 +148
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
84af1be to
35b6dd3
Compare
… to link a new device. This will be merged together with the existing QRCodeLoginScreen.
35b6dd3 to
20505d2
Compare
Velin92
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I would have put the QR Code scanning refactor into a separate PR
|
Ah yeah sorry, I could've split this one up better in the end. |
Notes:
CheckCodeSender::validate()matrix-org/matrix-rust-sdk#5957 (but everything is behind a feature flag so it is safe to merge).