Add MXLog.dev for faster print debugging. #3694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
force-pushed
the
doug/mxlog-dev
branch
from
4339968 to
e726d81
Compare
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #3694 +/- ##
===========================================
+ Coverage 78.67% 78.69% +0.02%
===========================================
Files 792 792
Lines 67731 67734 +3
===========================================
+ Hits 53285 53306 +21
+ Misses 14446 14428 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than doing
MXLog.info("[DOUG] Something happened")in a bunch of places (to then filter the console on [DOUG]), this PR addsMXLog.dev("Something happened")which automatically prefixes the current user's name (from their home directory) to the log.Only available in DEBUG mode, and probably not useful on a device.
The second commit removes the
contextfrom MXLog as it is completely unused and seems unlikely we'll hook it up any time soon given what is available from Rust.