Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM Design Tweaks #3693

Merged
merged 7 commits into from
Jan 22, 2025
Merged

DM Design Tweaks #3693

merged 7 commits into from
Jan 22, 2025

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jan 21, 2025

  • Added a Profile button that brings you to the room member detail of the DM recipient.
  • Removed the stacked avatars in DMs
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-01-21.at.15.52.49.mp4

@Velin92 Velin92 requested a review from a team as a code owner January 21, 2025 14:47
@Velin92 Velin92 requested review from pixlwave and removed request for a team January 21, 2025 14:47
@Velin92 Velin92 force-pushed the mauroromito/dm_design_tweaks branch from b9b521a to 5ff8f46 Compare January 21, 2025 14:49
@Velin92 Velin92 added the pr-change for updates to an existing feature label Jan 21, 2025
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 thought on the implementation while we wait to hear back on the Profile button. But otherwise looks good to me.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 10 lines in your changes missing coverage. Please review.

Project coverage is 78.68%. Comparing base (f194285) to head (8d9603b).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...RoomDetailsScreen/RoomDetailsScreenViewModel.swift 20.00% 4 Missing ⚠️
...Sources/FlowCoordinators/RoomFlowCoordinator.swift 0.00% 2 Missing ⚠️
...omDetailsScreen/RoomDetailsScreenCoordinator.swift 0.00% 2 Missing ⚠️
...ens/RoomDetailsScreen/View/RoomDetailsScreen.swift 84.61% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3693      +/-   ##
===========================================
+ Coverage    78.66%   78.68%   +0.02%     
===========================================
  Files          792      792              
  Lines        67734    67742       +8     
===========================================
+ Hits         53283    53303      +20     
+ Misses       14451    14439      -12     
Flag Coverage Δ
unittests 70.19% <71.42%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 requested a review from pixlwave January 21, 2025 18:48
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@Velin92 Velin92 force-pushed the mauroromito/dm_design_tweaks branch from 7a141d0 to 8d9603b Compare January 22, 2025 13:08
@Velin92 Velin92 requested a review from pixlwave January 22, 2025 13:09
@Velin92 Velin92 enabled auto-merge (squash) January 22, 2025 13:13
@Velin92 Velin92 merged commit 48e530f into develop Jan 22, 2025
8 checks passed
@Velin92 Velin92 deleted the mauroromito/dm_design_tweaks branch January 22, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants