Possible fix for the join room screen not updating

[Velin92]

Not sure if this is the best way to fix the issue given the API change to the room preview API that has been made, but once the request was sent, the state of the joined room was not updated, since the room preview was checked first but never updated.
Example:

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-01-21.at.11.26.11.mp4

This should however fix the issue:

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-01-21.at.11.43.52.mp4

[Velin92]

I wonder if we shouldn't switch around this code:

        switch roomPreview.info.membership {
          case .invited:
              state.mode = .invited
          case .knocked:
              state.mode = .knocked
          case .banned:
              state.mode = .banned(sender: membershipDetails?.senderRoomMember?.displayName ?? membershipDetails?.senderRoomMember?.userID,
                                   reason: membershipDetails?.ownRoomMember.membershipChangeReason)
          default:
              switch roomPreview.info.joinRule {
              case .private, .invite:
                  state.mode = .inviteRequired
              case .knock, .knockRestricted:
                  state.mode = appSettings.knockingEnabled ? .knockable : .joinable
              case .restricted:
                  state.mode = .restricted
              default:
                  state.mode = .joinable
              }
          }
      } else if let room {
          switch room {
          case .invited:
              state.mode = .invited
          case .knocked:
              state.mode = .knocked
          case .banned:
              state.mode = .banned(sender: nil, reason: nil)
          default:
              state.mode = .joinable
          }
      }
  }

So that the room takes priority over the room preview, however I already tried this, and what happens is that the preview won't render the knockable state if I do so, so what I did for now is just also refresh the room preview after we refresh the room, when a change has been made @stefanceriu

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.58%. Comparing base (8577f53) to head (cbcef1f).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...reens/JoinRoomScreen/JoinRoomScreenViewModel.swift	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3690      +/-   ##
===========================================
- Coverage    78.66%   78.58%   -0.08%     
===========================================
  Files          792      792              
  Lines        67700    67700              
===========================================
- Hits         53253    53201      -52     
- Misses       14447    14499      +52     

Flag	Coverage Δ
unittests	70.12% <0.00%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[pixlwave]

LGTM 👍