blog: ecosystem node 22 update blog #698
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzhao
changed the title
VerteDinde
force-pushed
the
node-22-blog
branch
from
df10cd0 to
848fd83
Compare
Deploying electron-website with
|
| Latest commit: |
b3100af
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://28fbb081.electron-website.pages.dev |
| Branch Preview URL: | https://node-22-blog.electron-website.pages.dev |
erickzhao
requested changes
Dec 2, 2024
Co-authored-by: Erick Zhao <[email protected]>
|
Looks good to me! 👍 |
ckerr
reviewed
Dec 3, 2024
| - Lack of official Node.js 14 macOS ARM64 builds requires us to maintain CI infrastructure workarounds to provide full test coverage. | ||
| - `engines` requirements for upstream package dependencies have moved forward, making it increasingly difficult to resolve supply chain security issues with dependency bumps. | ||
|
|
||
| Additionally, newer versions of Node.js have included many improvements that we would like to leverage, such as runtime-native common utilities (e.g. [`fs.glob`](https://nodejs.org/api/fs.html#fsglobpattern-options-callback) and [`util.parseArgs`](https://nodejs.org/api/util.html#utilparseargsconfig)) and entire new batteries-included modules (e.g. [`node:test`](https://nodejs.org/api/test.html), [`node:sqlite`](https://nodejs.org/api/sqlite.html)). |
There was a problem hiding this comment.
I'm not sure about this one, but should this paragraph be a third bullet point in the previous list? Fits the rule of three
|
|
||
| We’ll strive to maintain compatibility as much as possible. However, to ensure the best support, we encourage you to upgrade your apps to Node 22 or higher. | ||
|
|
||
| Note that the Node version running in your project is unrelated to the Node version embedded into your current version of Electron. |
There was a problem hiding this comment.
This is a good start but I'd go even further, e.g. explaining if your app uses Node 21 but doesn't use any ecosystem apps, they don't need to make any changes (I think?)
Co-authored-by: Charles Kerr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a blog/announcement for our plan to move the ecosystem packages to Node 22
NOTE: Please hold merging this until Jan 1, 2025