-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: define practices for third-party extensible APIs #586
Merged
samuelmaddock
merged 5 commits into
electron:main
from
samuelmaddock:docs/extensible-apis
Oct 10, 2024
Merged
docs: define practices for third-party extensible APIs #586
samuelmaddock
merged 5 commits into
electron:main
from
samuelmaddock:docs/extensible-apis
Oct 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Will Anderson <[email protected]>
Co-authored-by: Will Anderson <[email protected]>
samuelmaddock
force-pushed
the
docs/extensible-apis
branch
from
October 3, 2024 20:35
69f98bf
to
2ac1df9
Compare
5 tasks
jkleinsc
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
itsananderson
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well. Sorry I forgot to come back and stamp after your updates 😅
Thanks for your work on this! |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few of Electron's existing APIs don't do a good job of supporting extensibility for third-party libraries. Let's try to define best practices to guide future API designs with third-party extensibility in mind.
protocol.registerSchemesAsPrivileged
registerSchemesAsPrivileged
cannot be used by libraries electron#40362session.setPreloads
/session.getPreloads