Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: github publisher does not support update.electronjs.org #3344

Closed
wants to merge 1 commit into from

Conversation

kilbot
Copy link

@kilbot kilbot commented Sep 11, 2023

update.electronjs.org requires latest-mac.yml files to work. The github piublisher does not produce latest.yml files so update.electronjs.org will not work.

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

The documentation about the GitHub Publisher is misleading, you can not use update.electronjs.org unless you create your own latest-mac.yml files.

update.electronjs.org requires latest.yml files to work. The github piublisher does not produce latest.yml files so update.electronjs.org will not work.
@kilbot kilbot requested a review from a team as a code owner September 11, 2023 11:23
@kilbot kilbot changed the title Update github publisher docs docs: github publisher does not support update.electronjs.org Sep 13, 2023
@kilbot
Copy link
Author

kilbot commented Sep 13, 2023

I see now that the problem is more that electron-forge and electron-updater are incompatible. Which is guess makes sense as electron-updater seems to be tightly coupled to electron-builder.

Perhaps there should be a 'gotchas' section for people migrating from electron-updater, because the auto-update process seems like taking a step backwards.

@erickzhao erickzhao closed this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants