Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: undocument npm install -g #3314

Merged
merged 4 commits into from
Sep 7, 2023
Merged

chore: undocument npm install -g #3314

merged 4 commits into from
Sep 7, 2023

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Aug 22, 2023 •
edited by malept
Loading

🚯

Fixes #3305

@erickzhao erickzhao marked this pull request as ready for review August 22, 2023 22:56
@erickzhao erickzhao requested a review from a team as a code owner August 22, 2023 22:56
@erickzhao erickzhao requested a review from a team August 22, 2023 22:56
malept
malept approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine but we should document what to do if a template isn't found

georgexu99
georgexu99 approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@georgexu99 georgexu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a victim i approve

@erickzhao erickzhao merged commit 8c53af6 into main Sep 7, 2023
3 checks passed
@erickzhao erickzhao deleted the chore/undocument-npm-install-g branch September 7, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgexu99 georgexu99 georgexu99 approved these changes

@dsanders11 dsanders11 dsanders11 approved these changes

@malept malept malept approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI should not ask users to globally install templates
4 participants
@erickzhao @malept @dsanders11 @georgexu99