Don't make requiredExternalBinaries an abstract property

electron · Nov 30, 2019 · cb65690 · cb65690
1 parent eccbb47
commit cb65690
Show file tree

Hide file tree

Showing 11 changed files with 5 additions and 21 deletions.
diff --git a/packages/api/core/src/api/make.ts b/packages/api/core/src/api/make.ts
@@ -24,8 +24,6 @@ class MakerImpl extends MakerBase<any> {
   name = 'impl';
 
   defaultPlatforms = [];
-
-  requiredExternalBinaries = [];
 }
 
 export interface MakeOptions {

diff --git a/packages/maker/appx/src/MakerAppX.ts b/packages/maker/appx/src/MakerAppX.ts
@@ -81,8 +81,6 @@ export default class MakerAppX extends MakerBase<MakerAppXConfig> {
 
   defaultPlatforms: ForgePlatform[] = ['win32'];
 
-  requiredExternalBinaries: string[] = [];
-
   isSupportedOnCurrentPlatform() {
     return process.platform === 'win32';
   }

diff --git a/packages/maker/base/src/Maker.ts b/packages/maker/base/src/Maker.ts
@@ -44,7 +44,7 @@ export default abstract class Maker<C> implements IForgeMaker {
 
   public abstract defaultPlatforms: ForgePlatform[];
 
-  public abstract requiredExternalBinaries: string[] = [];
+  public requiredExternalBinaries: string[] = [];
 
   __isElectronForgeMaker!: true;
 

diff --git a/packages/maker/base/test/ensure-output_spec.ts b/packages/maker/base/test/ensure-output_spec.ts
@@ -9,8 +9,6 @@ class MakerImpl extends MakerBase<{}> {
   name = 'test';
 
   defaultPlatforms = [];
-
-  requiredExternalBinaries = [];
 }
 
 describe('ensure-output', () => {

diff --git a/packages/maker/dmg/src/MakerDMG.ts b/packages/maker/dmg/src/MakerDMG.ts
@@ -11,8 +11,6 @@ export default class MakerDMG extends MakerBase<MakerDMGConfig> {
 
   defaultPlatforms: ForgePlatform[] = ['darwin', 'mas'];
 
-  requiredExternalBinaries: string[] = [];
-
   isSupportedOnCurrentPlatform() {
     return process.platform === 'darwin';
   }

diff --git a/packages/maker/flatpak/test/MakerFlatpak_spec.ts b/packages/maker/flatpak/test/MakerFlatpak_spec.ts
@@ -11,9 +11,9 @@ import { flatpakArch } from '../src/MakerFlatpak';
 import { MakerFlatpakConfig } from '../src/Config';
 
 class MakerImpl extends MakerBase<MakerFlatpakConfig> {
- name = 'test';
+  name = 'test';
 
- defaultPlatforms = [];
+  defaultPlatforms = [];
 }
 
 describe('MakerFlatpak', () => {

diff --git a/packages/maker/pkg/src/MakerPKG.ts b/packages/maker/pkg/src/MakerPKG.ts
@@ -11,8 +11,6 @@ export default class MakerDMG extends MakerBase<MakerPKGConfig> {
 
   defaultPlatforms: ForgePlatform[] = ['darwin', 'mas'];
 
-  requiredExternalBinaries: string[] = [];
-
   isSupportedOnCurrentPlatform() {
     return process.platform === 'darwin';
   }

diff --git a/packages/maker/rpm/test/MakerRpm_spec.ts b/packages/maker/rpm/test/MakerRpm_spec.ts
@@ -10,9 +10,9 @@ import { MakerRpmConfig } from '../src/Config';
 import { rpmArch } from '../src/MakerRpm';
 
 class MakerImpl extends MakerBase<MakerRpmConfig> {
- name = 'test';
+  name = 'test';
 
- defaultPlatforms = [];
+  defaultPlatforms = [];
 }
 
 describe('MakerRpm', () => {

diff --git a/packages/maker/squirrel/src/MakerSquirrel.ts b/packages/maker/squirrel/src/MakerSquirrel.ts
@@ -12,8 +12,6 @@ export default class MakerSquirrel extends MakerBase<MakerSquirrelConfig> {
 
   defaultPlatforms: ForgePlatform[] = ['win32'];
 
-  requiredExternalBinaries: string[] = [];
-
   isSupportedOnCurrentPlatform() {
     return this.isInstalled('electron-winstaller') && !process.env.DISABLE_SQUIRREL_TEST;
   }

diff --git a/packages/maker/wix/src/MakerWix.ts b/packages/maker/wix/src/MakerWix.ts
@@ -14,8 +14,6 @@ export default class MakerWix extends MakerBase<MakerWixConfig> {
 
   defaultPlatforms: ForgePlatform[] = ['win32'];
 
-  requiredExternalBinaries: string[] = [];
-
   isSupportedOnCurrentPlatform() {
     return process.platform === 'win32';
   }

diff --git a/packages/maker/zip/src/MakerZIP.ts b/packages/maker/zip/src/MakerZIP.ts
@@ -11,8 +11,6 @@ export default class MakerZIP extends MakerBase<MakerZIPConfig> {
 
   defaultPlatforms: ForgePlatform[] = ['darwin', 'mas', 'win32', 'linux'];
 
-  requiredExternalBinaries: string[] = [];
-
   isSupportedOnCurrentPlatform() {
     return true;
   }