Update toolchain to 1.78 and fix 'multi_get' #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anelson
approved these changes
May 28, 2024
|
Ugh, MacOS build fails on 14.5, but works on 14.4.1. And build agents are random |
|
Fix for MacOS 14.5 worked, I've run it in a separate draft PR https://github.com/elastio/roxide/actions/runs/9284577585/job/25547314936?pr=46 (because in this one CI/CD ran on 14.4). Reported build failure to RocksDB here - facebook/rocksdb#12708 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After update to 1.78, tests started failing on these asserts.
multi_getstarted failing for a case whenkeysparameter is an empty iterator.Because of that, many tests started failing here - https://github.com/elastio/scalez/pull/653