Update RocksDB to 9.0.0 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anelson
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Sorry I got wrapped around the axle, roxide-rocksdb is from the upstream rocksdb code base, I assume you pulled in the latest version and that's what all of those diffs are from. I couldn't figure out why the code base was so weird and unfamiliar.
Ignore my questions, this LGTM.
roxide-rocksdb/src/column_family.rs
Outdated
| } | ||
|
|
||
| /// An opaque type used to represent a column family. Returned from some functions, and used | ||
| /// in others | ||
| pub struct ColumnFamily { | ||
| pub(crate) inner: *mut ffi::rocksdb_column_family_handle_t, | ||
| pub inner: *mut ffi::rocksdb_column_family_handle_t, |
There was a problem hiding this comment.
Yikes, why are the inner pointers all public now?
There was a problem hiding this comment.
I've accidentally overdid it. They are pub(crate) in the original repo, but in some of these structs you've explicitly changed access to pub to use in roxide. I'll revert this and leave only those which are really needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/elastio/scalez/issues/641