Update RocksDB to 9.0.0 #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alysenko-polytech
force-pushed
the
feat/641-update-rocksdb-9.0.0
branch
3 times, most recently
from
f6a1a6f to
e9325da
Compare
alysenko-polytech
force-pushed
the
feat/641-update-rocksdb-9.0.0
branch
from
cc71e67 to
2864373
Compare
alysenko-polytech
requested review from
anelson
and removed request for
anelson
/// Verifies that, absent our polyfill, the Rocks iterator on a transaction ignores range
/// parameters when creating an iterator.
///
/// Hopefully some day https://github.com/facebook/rocksdb/issues/2343 is fixed and this test
/// breaks. If that happens, rejoice, delete the `TransactionRangeIterator`, and simplify the
/// iterator code immensely!
Huh, they did fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/elastio/scalez/issues/641