Return detailed errors on DB open instead of a single string. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alysenko-polytech
force-pushed
the
bug/626-data-corruption
branch
from
b49219c to
a716dbb
Compare
anelson
approved these changes
Apr 5, 2024
Also, get_sst_files -> get_live_info. Updated function now also returns sequence number from the opened checkpoint DB. Part of elastio/scalez#626
alysenko-polytech
force-pushed
the
bug/626-data-corruption
branch
from
a716dbb to
fb0ff63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to return
RocksDbErrorwith properStatusand RocksDB error codes, instead ofDatabaseErrorwith a singlemessagestring. This will allow us to handleCorruptederror code in scope of https://github.com/elastio/scalez/issues/626.DB open functions, defined here, are almost exact copies of corresponding functions in
c.h/c.cc, but returnCppStatusinstead of error string.Also,
get_sst_filesgot renamed intoget_live_info. Updated function now also returns sequence number from the opened checkpoint DB.