Fix RocksDB ccache cache misses leading to pointless recompilations
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `cc` recompiled `rocksdb` every time after the slightest changes to `cargo` command (e.g. running cargo doc after `cargo check` resulted in recompilation of `rocksdb` C++ code, even if C++ code didn't change at all. This was due to use of absolute paths containing e.g. `roxide-librocksdb-sys-c294a8e66ff58e21`, where `c294a8e66ff58e21` part changed after the slightest change to `cargo` command. - Move dummy wrapper files: `target/` -> `roxide-librocksdb-sys/build/` - Perform cosmetic changes to comments - Add a reminder to investigate if wrapper files hack is still needed Closes #11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
ccrecompiledrocksdbevery time after the slightest changes tocargocommand (e.g. runningcargo docaftercargo checkresulted in recompilation ofrocksdbC++ code, even if C++ code didn't change at all. This was due to use of absolute paths containing e.g.roxide-librocksdb-sys-c294a8e66ff58e21, wherec294a8e66ff58e21part changed after the slightest change tocargocommand.target/ -> roxide-librocksdb-sys/build/Closes #11