Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: health report first pass #16513

Draft
wants to merge 3 commits into
base: 8.x
Choose a base branch
from
Draft

Conversation

yaauie
Copy link
Member

@yaauie yaauie commented Oct 7, 2024

Release notes

Adds documentation for Health Report API

What does this PR do?

Adds the health report docs that are also added in #16398 as a way of triggering docs CI, which is bypassed in that PR since it targets feature/* which isn't allowlisted for docs builds.

@yaauie yaauie added the docs label Oct 7, 2024
Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explanations from technical point of view looks great!
It would be great if we get input from @karenzone for the rest (structure, etc..).

========

`diagnosis`::
(Optional, array) If a non-healthy status is returned, indicators may include a list of diagnosis that encapsulate the cause of the health issue and an action to take in order to remediate the problem.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆 (as a non-native-speaker this is my most-time mistake diagnosis vs diagnoses 🙈)

Suggested change
(Optional, array) If a non-healthy status is returned, indicators may include a list of diagnosis that encapsulate the cause of the health issue and an action to take in order to remediate the problem.
(Optional, array) If a non-healthy status is returned, indicators may include a list of diagnoses that encapsulate the cause of the health issue and an action to take in order to remediate the problem.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a verbatim from the Elasticsearch docs 😩

========

`diagnosis`::
(Optional, array) If a non-healthy status is returned, indicators may include a list of diagnosis that encapsulate the cause of the health issue and an action to take in order to remediate the problem.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a verbatim from the Elasticsearch docs 😩

docs/static/monitoring/monitoring-apis.asciidoc Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants