[8.x] Override all codeowners #197710
Closed
[8.x] Override all codeowners #197710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to preserve CODEOWNERS for other automation, and to reduce the number of merge conflicts on backports, but avoid notifications on backports where these reviews aren't required. This assigns kibanamachine as the owner of all files.
jbudz
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
|
Converting to draft for the moment, I need to run some tests on assignment when kibanamachine is the PR author. |
pheyos
reviewed
Oct 29, 2024
⏳ Build in-progress, with failures
Failed CI StepsTest Failures |
|
Glad there was a test. I see at least 4 different implementations of CODEOWNERS parsing that will need to be updated to skip the last entry. I'll revisit this starting from main. |
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Ikuni17
added a commit
that referenced
this pull request
Oct 30, 2024
Temporary removal of `CODEOWNERS` to stop review notifications until #197710 issues are resolved.
|
Closing in favor of #199686 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On older release branches we want to preserve CODEOWNERS for other automation, and to reduce the number of merge conflicts on backports.
We also don't want reviewer assigned and the subsequent notifications sent when these reviews are not a requirement.
This assigns kibanamachine as the owner of all files.