Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Consume elasticsearch.publicBaseUrl where possible (#192741) #193442

Open
wants to merge 1 commit into
base: 8.x
Choose a base branch
from
Open

[8.x] Consume elasticsearch.publicBaseUrl where possible (#192741) #193442

wants to merge 1 commit into from
+234 −73

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@sphilipse
Consume elasticsearch.publicBaseUrl where possible (elastic#192741)
9f3e11c 
## Summary

This actually consumes the public base url in the cloud plugin and the
places depending on the `elasticsearchUrl` value populated there.

---------

Co-authored-by: Rodney Norris <[email protected]>
(cherry picked from commit b4a7b2e)
@kibanamachine kibanamachine enabled auto-merge (squash) September 19, 2024 15:02
@kibanamachine kibanamachine mentioned this pull request Sep 19, 2024
Merged
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 19, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #9 / Create does not render default value when setDefaultValue is false
  • [job] [logs] Jest Tests #9 / EditableMarkdown Save button click calls onSaveContent and onChangeEditable when text area value changed

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB +448.0B
fleet 1.8MB 1.8MB +122.0B
home 151.9KB 152.0KB +53.0B
indexManagement 679.6KB 679.7KB +45.0B
searchHomepage 54.8KB 54.8KB +53.0B
searchIndices 69.3KB 69.5KB +196.0B
searchPlayground 151.1KB 151.2KB +84.0B
serverlessSearch 326.9KB 327.2KB +368.0B
total +1.3KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
cloud 0 1 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloud 7.1KB 7.6KB +464.0B
cloudLinks 30.1KB 30.2KB +53.0B
total +517.0B
Unknown metric groups

API count

id before after diff
@kbn/core-elasticsearch-server 117 118 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sphilipse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions approved these changes

Assignees

@sphilipse sphilipse

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kibanamachine @kibana-ci @sphilipse