Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] remove DashboardExternallyAccessibleApi and DashboardPluginInternalFunctions types #193440

Merged
merged 4 commits into from
Sep 19, 2024
Merged

[dashboard] remove DashboardExternallyAccessibleApi and DashboardPluginInternalFunctions types #193440

merged 4 commits into from
Sep 19, 2024
+17 −82

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Sep 19, 2024 •
edited by kibanamachine
Loading

Consolidate to only exposing DashboardApi by removing DashboardExternallyAccessibleApi and DashboardPluginInternalFunctions types.

@nreese
Copy link
Contributor Author

nreese commented Sep 19, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Sep 19, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Sep 19, 2024

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Sep 19, 2024

/ci

@nreese nreese changed the title remove old types [dashboard] remove DashboardExternallyAccessibleApi and DashboardPluginInternalFunctions types Sep 19, 2024
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #40 / SLO API Tests Delete SLOs deletes new slo saved object and transforms

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 481.7KB 481.7KB +8.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes v9.0.0 project:embeddableRebuild v8.16.0 labels Sep 19, 2024
@nreese nreese marked this pull request as ready for review September 19, 2024 20:36
@nreese nreese requested a review from a team as a code owner September 19, 2024 20:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese added backport:prev-major Backport to the previous major branch and all later branches still in development backport:version Backport to applied version labels and removed backport:prev-major Backport to the previous major branch and all later branches still in development labels Sep 19, 2024
Heenawter
Heenawter approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review - changes are straightforward and LGTM 👍

@nreese nreese merged commit 885dfe3 into elastic:main Sep 19, 2024
28 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 19, 2024
@nreese
[dashboard] remove DashboardExternallyAccessibleApi and DashboardPlug…
f8af7ec 
…inInternalFunctions types (elastic#193440)

Consolidate to only exposing `DashboardApi` by removing
`DashboardExternallyAccessibleApi` and
`DashboardPluginInternalFunctions` types.

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 885dfe3)
@kibanamachine kibanamachine mentioned this pull request Sep 19, 2024
Open
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Heenawter Heenawter Heenawter approved these changes

Assignees
No one assigned
Labels
backport:version Backport to applied version labels project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nreese @kibana-ci @elasticmachine @kibanamachine @Heenawter