Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard][Usability] Allow overflow y inline edit mode #193430

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rshen91
Copy link
Contributor

@rshen91 rshen91 commented Sep 19, 2024

Summary

Closes [Bug] Upper part of the chart is hidden when user edits a chart inline · Issue #192437 · elastic/kibana · GitHub

This PR disables the overflow-y hidden css and allows users to scroll to the top of the visualization in inline editing mode.

Now:

Sep-19-2024.08-11-03.mp4

Checklist

  • Unit or functional tests were updated or added to match the most common scenarios
  • Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
  • Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)

@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 19, 2024

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!

@rshen91 rshen91 self-assigned this Sep 19, 2024
@rshen91 rshen91 added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:fix backport:all-open Backport to all branches that could still receive a release labels Sep 19, 2024
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 19, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #95 / maps app dashboard reporting: creates a map report PNG file matches the baseline image, using sample geo data
  • [job] [logs] FTR Configs #95 / maps app dashboard reporting: creates a map report PNG file matches the baseline image, using sample geo data

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 481.2KB 481.3KB +104.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rshen91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:all-open Backport to all branches that could still receive a release release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Upper part of the chart is hidden when user edits a chart inline
3 participants