Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] [Attack discovery] Fixes a display issue when an entity is repeated #193428

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Security Solution] [Attack discovery] Fixes a display issue when an entity is repeated #193428

wants to merge 2 commits into from
+47 −8

Conversation

andrew-goldstein
Copy link
Contributor

[Security Solution] [Attack discovery] Fixes a display issue when an entity is repeated

Summary

This PR fixes a display issue in Attack discovery where entities repeated in a description were displayed with a UUID instead of the value, as illustrated by the Before and After screenshots below:

Before

before

After

after

@andrew-goldstein
## [Security Solution] [Attack discovery] Fixes a display issue when …
cbcd8fc 
…an entity is repeated

### Summary

This PR fixes a display issue in Attack discovery where entities repeated in a description were displayed with a UUID instead of the value, as illustrated by the _Before_ and _After_ screenshots below:

**Before**

![before](https://github.com/user-attachments/assets/9197c9b0-27d2-4f46-a967-35bb8ca254d0)

**After**

![after](https://github.com/user-attachments/assets/2d7c16bd-972c-45cc-a22f-abe7c8c6c019)
@andrew-goldstein andrew-goldstein added bug Fixes for quality problems that affect the customer experience v9.0.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0 v8.15.2 labels Sep 19, 2024
@andrew-goldstein andrew-goldstein self-assigned this Sep 19, 2024
@andrew-goldstein andrew-goldstein requested a review from a team as a code owner September 19, 2024 14:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@andrew-goldstein andrew-goldstein added release_note:fix backport:prev-minor Backport to the previous minor version (i.e. one version back from main) labels Sep 19, 2024
@andrew-goldstein
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.4MB 20.4MB +70.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @andrew-goldstein

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andrew-goldstein andrew-goldstein

Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.15.2 v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrew-goldstein @elasticmachine @kibana-ci