Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML][Rules] Check interval input box on Create ML anomaly detection rule error after deleting input fix #193420

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[ML][Rules] Check interval input box on Create ML anomaly detection rule error after deleting input fix #193420

wants to merge 2 commits into from
+7 −7

Conversation

rbrtj
Copy link
Contributor

@rbrtj rbrtj commented Sep 19, 2024 •
edited
Loading

Summary

Related to #190732
It was trying to parse null values.
After:
image

@rbrtj rbrtj added release_note:fix :ml Team:ML Team label for ML (also use :ml) labels Sep 19, 2024
@rbrtj rbrtj self-assigned this Sep 19, 2024
@rbrtj rbrtj requested a review from a team as a code owner September 19, 2024 12:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@rbrtj rbrtj added v8.16.0 backport:version Backport to applied version labels backport:skip This commit does not require backporting and removed v8.16.0 backport:version Backport to applied version labels labels Sep 19, 2024
darnautov
darnautov reviewed Sep 19, 2024
View reviewed changes
...rity_solution/docs/openapi/ess/security_solution_timeline_api_2023_10_31.bundled.schema.yaml
@@ -131,7 +131,7 @@ paths:
type: string
required:
- note
description: 'The note to add or update, along with additional metadata.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rbrtj I wonder what triggered these changes?

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 19, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #47 / console app misc console behavior keyboard shortcuts should execute the request when Ctrl+Enter is pressed
  • [job] [logs] FTR Configs #47 / console app misc console behavior keyboard shortcuts should execute the request when Ctrl+Enter is pressed
  • [job] [logs] Jest Tests #6 / FilePreview pressing escape calls closePreview
  • [job] [logs] FTR Configs #11 / Reporting APIs Network Policy "after all" hook for "should fail job when page violates the network policy"
  • [job] [logs] FTR Configs #11 / Reporting APIs Network Policy "after all" hook for "should fail job when page violates the network policy"
  • [job] [logs] FTR Configs #11 / Reporting APIs Network Policy should fail job when page violates the network policy
  • [job] [logs] FTR Configs #11 / Reporting APIs Network Policy should fail job when page violates the network policy

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.6MB 4.6MB +34.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rbrtj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darnautov darnautov darnautov left review comments

@peteharverson peteharverson Awaiting requested review from peteharverson

At least 1 approving review is required to merge this pull request.

Assignees

@rbrtj rbrtj

Labels
backport:skip This commit does not require backporting :ml release_note:fix Team:ML Team label for ML (also use :ml)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rbrtj @elasticmachine @kibana-ci @darnautov @kibanamachine