Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug logging for flaky session tests #193279

Merged

Conversation

SiddharthMantri
Copy link
Contributor

@SiddharthMantri SiddharthMantri commented Sep 18, 2024

Summary

Add settings to the ES Test cluster to enable debug logs so that if this test fails in the future, we will have more logs to investigate the issue.

Related: #152260

@SiddharthMantri SiddharthMantri requested a review from a team as a code owner September 18, 2024 12:02
Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SiddharthMantri SiddharthMantri enabled auto-merge (squash) September 18, 2024 13:45
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @SiddharthMantri

@SiddharthMantri SiddharthMantri merged commit de51a1a into elastic:main Sep 18, 2024
21 checks passed
@kibanamachine kibanamachine added v9.0.0 backport:skip This commit does not require backporting labels Sep 18, 2024
@SiddharthMantri SiddharthMantri added backport:all-open Backport to all branches that could still receive a release and removed backport:skip This commit does not require backporting labels Sep 19, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 19, 2024
## Summary

Add settings to the ES Test cluster to enable debug logs so that if this
test fails in the future, we will have more logs to investigate the
issue.

__Related:__ elastic#152260

(cherry picked from commit de51a1a)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 19, 2024
## Summary

Add settings to the ES Test cluster to enable debug logs so that if this
test fails in the future, we will have more logs to investigate the
issue.

__Related:__ elastic#152260

(cherry picked from commit de51a1a)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
7.17 Backport failed because of merge conflicts
8.15
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 193279

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 19, 2024
# Backport

This will backport the following commits from `main` to `8.15`:
- [Add debug logging for flaky session tests
(#193279)](#193279)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Sid","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-18T17:01:45Z","message":"Add
debug logging for flaky session tests (#193279)\n\n## Summary\r\n\r\nAdd
settings to the ES Test cluster to enable debug logs so that if
this\r\ntest fails in the future, we will have more logs to investigate
the\r\nissue.\r\n\r\n\r\n__Related:__
#152260
debug logging for flaky session
tests","number":193279,"url":"#193279
debug logging for flaky session tests (#193279)\n\n## Summary\r\n\r\nAdd
settings to the ES Test cluster to enable debug logs so that if
this\r\ntest fails in the future, we will have more logs to investigate
the\r\nissue.\r\n\r\n\r\n__Related:__
#152260
debug logging for flaky session tests (#193279)\n\n## Summary\r\n\r\nAdd
settings to the ES Test cluster to enable debug logs so that if
this\r\ntest fails in the future, we will have more logs to investigate
the\r\nissue.\r\n\r\n\r\n__Related:__
#152260"}}]}]
BACKPORT-->

Co-authored-by: Sid <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes v8.15.2 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants