[Console] Allow mixed case methods #190527

yuliacech · 2024-08-14T16:28:28Z

Summary

Fixes https://github.com//elastic/kibana/issues/186774

This PR adds a new function to the parser to allow mixed case methods like GeT, posT etc

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Flaky Test Runner was used on any tests changed
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

…id and the parser can't parse the next request

yuliacech · 2024-08-20T13:06:38Z

/ci

elasticmachine · 2024-08-20T13:48:18Z

Pinging @elastic/kibana-management (Team:Kibana Management)

…-fix'

kibana-ci · 2024-08-20T15:24:26Z

💚 Build Succeeded

Buildkite Build
Commit: cdb7f70

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sabarasaba

Nice work @yuliacech! I was just testing this locally and found some strange behaviour when you have multiple requests writen in the editor and one of them has an invalid method

Screen.Recording.2024-08-21.at.09.44.01.mov

Seems that:

When clicking the play button of the first request with invalid method a 500error is shown in the output but without anything inside (but no request was made)
When I click on the second (and valid) request the first request is also selected as if its all part of the same request, and upon executing we have the same problem as above

sabarasaba · 2024-08-21T07:44:47Z

test/functional/apps/console/monaco/_console.ts

        await sendMultipleRequests(['\n GET _search/test', '\n GET _search']);
        await PageObjects.header.waitUntilLoadingHasFinished();
-        expect(await PageObjects.console.hasWarningBadge()).to.be(true);
-        expect(await PageObjects.console.hasSuccessBadge()).to.be(true);
+        expect(await PageObjects.console.monaco.hasWarningBadge()).to.be(true);


Thanks for patching this up too!

yuliacech · 2024-09-19T15:49:53Z

Closing in favour of #193445

## Summary Fixes https://github.com//elastic/kibana/issues/186774 This PR is re-opened from #190527 after too many merge conflicts. This PR adds a new function to the parser to allow mixed case methods like GeT, posT etc ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

yuliacech and others added 22 commits August 1, 2024 20:52

[Console] Fix the end line for the request, when the request is inval…

edaa7a6

…id and the parser can't parse the next request

Merge branch 'main' into console/fix_invalid_requests

6fee08d

[Console] Fix invalid requests

2ddbda0

Merge branch 'main' into console/fix_invalid_requests

818555b

[Console] Fix tests

658cf76

Merge branch 'main' into console/fix_invalid_requests

fd3c294

[Console] Remove method, url and data from the parser results

41d21b4

[Console] Add back tests, fix regressions

09d6c4d

[Console] More tests, more fixes

474168f

[Console] Update ftr tests

f8174d1

[Console] Fix parse line regressions

e8986d1

Merge branch 'main' into console/fix_invalid_requests

3fec945

[Console] Add tfr tests

f757f06

[Console] Fix get requests function

e69301e

[Console] Fix get requests function

7043920

[Console] Fix test

86e0a88

Merge branch 'main' into console/fix_invalid_requests

2cbffbf

[Console] Fix test

77803b7

[Console] Fix test

90c3be0

Merge branch 'main' into console/fix_invalid_requests

efcf4c0

[Console] Allow mixed case methods

cee68db

[Console] Add tests

4e25cb9

yuliacech added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes labels Aug 14, 2024

Merge branch 'main' into console/allow_mixed_case_methods

464630e

yuliacech marked this pull request as ready for review August 20, 2024 13:48

yuliacech requested review from a team as code owners August 20, 2024 13:48

yuliacech linked an issue Aug 20, 2024 that may be closed by this pull request

[Console][Monaco] Support for mixed-case and lower-case verbs #186774

Closed

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

cdb7f70

…-fix'

sabarasaba reviewed Aug 21, 2024

View reviewed changes

yuliacech closed this Sep 19, 2024

yuliacech mentioned this pull request Sep 20, 2024

[Console] Allow mixed case methods #193445

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Console] Allow mixed case methods #190527

[Console] Allow mixed case methods #190527

yuliacech commented Aug 14, 2024 •

edited

Loading

yuliacech commented Aug 20, 2024

elasticmachine commented Aug 20, 2024

kibana-ci commented Aug 20, 2024

sabarasaba left a comment

sabarasaba Aug 21, 2024

yuliacech commented Sep 19, 2024

[Console] Allow mixed case methods #190527

[Console] Allow mixed case methods #190527

Conversation

yuliacech commented Aug 14, 2024 • edited Loading

Summary

Checklist

Risk Matrix

For maintainers

yuliacech commented Aug 20, 2024

elasticmachine commented Aug 20, 2024

kibana-ci commented Aug 20, 2024

💚 Build Succeeded

Metrics [docs]

sabarasaba left a comment

Choose a reason for hiding this comment

sabarasaba Aug 21, 2024

Choose a reason for hiding this comment

yuliacech commented Sep 19, 2024

yuliacech commented Aug 14, 2024 •

edited

Loading