Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] fix functional visualize app test #190016

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

tsullivan
Copy link
Member

Summary

Unskip functional test. Closes #189590

@tsullivan
Copy link
Member Author

/ci

@tsullivan tsullivan added the release_note:skip Skip the PR/issue when compiling release notes label Aug 6, 2024
@tsullivan
Copy link
Member Author

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6713

[✅] x-pack/test/functional/apps/visualize/config.ts: 42/42 tests passed.

see run history

@tsullivan
Copy link
Member Author

Seems this test is not flaky after all as it passes in the flaky test runner. However, I don't know why the main issue states there was an error of TypeError: Invalid URL. @mistic can you take a look?

@tsullivan tsullivan marked this pull request as ready for review August 7, 2024 22:15
@tsullivan tsullivan changed the title Reporting/fix functional visualize app test [Reporting] fix functional visualize app test Aug 7, 2024
@tsullivan tsullivan added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Aug 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsullivan cherry-picked your changes into a branch on Kibana repo and run the pipeline on that branch. I'm not sure why but the pipeline still fails with those tests https://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4627#019138df-1849-462e-acec-063307e236aa

I think it's a good idea to open the PR with the unskip in a branch on Kibana repo so we can test more things on the pipeline itself.

At this point I'm not sure what could cause those failres. @jbudz maybe do you have any idea?

@jbudz
Copy link
Member

jbudz commented Aug 9, 2024

This test is running against a cloud deployment. Did we verify it runs there?

I think it's a good idea to open the PR with the unskip in a branch on Kibana repo so we can test more things on the pipeline itself.

Pipelines can run against pull requests, set the branch to pull/190016/head

@tsullivan
Copy link
Member Author

Pipelines can run against pull requests, set the branch to pull/190016/head

^^ @mistic

@mistic
Copy link
Member

mistic commented Aug 9, 2024

@jbudz I had that impression and tried it at https://buildkite.com/elastic/kibana-artifacts-snapshot/builds?branch=pull%2F190016...but now I know why it didn't work..I forgot about the last /head. @tsullivan even better, we can do the testing on that PR itself

For the record, I just started a new build based on the changes on this PR https://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4629

@tsullivan
Copy link
Member Author

@jbudz @mistic I'm not sure there are any action items for me on this. Is there anything I can do to help move this forward?

@jbudz
Copy link
Member

jbudz commented Aug 19, 2024

This test is running against a cloud deployment. Did we verify it runs there?

I haven't looked at it. Does this need help?

@jbudz
Copy link
Member

jbudz commented Aug 19, 2024

  1. Create cloud deployment
  2. Fill in environment variables, excluding TEST_BROWSER_HEADLESS and FORCE_COLOR
  3. Run FTR
    export TEST_KIBANA_PROTOCOL=$(node -e "console.log(new URL(process.env.CLOUD_DEPLOYMENT_KIBANA_URL).protocol.replace(':', ''))")
    export TEST_KIBANA_HOSTNAME=$(node -e "console.log(new URL(process.env.CLOUD_DEPLOYMENT_KIBANA_URL).hostname)")
    export TEST_KIBANA_PORT=$(node -e "console.log(new URL(process.env.CLOUD_DEPLOYMENT_KIBANA_URL).port || 443)")
    export TEST_KIBANA_USERNAME="$CLOUD_DEPLOYMENT_USERNAME"
    export TEST_KIBANA_PASSWORD="$CLOUD_DEPLOYMENT_PASSWORD"
    export TEST_ES_PROTOCOL=$(node -e "console.log(new URL(process.env.CLOUD_DEPLOYMENT_ELASTICSEARCH_URL).protocol.replace(':', ''))")
    export TEST_ES_HOSTNAME=$(node -e "console.log(new URL(process.env.CLOUD_DEPLOYMENT_ELASTICSEARCH_URL).hostname)")
    export TEST_ES_PORT=$(node -e "console.log(new URL(process.env.CLOUD_DEPLOYMENT_ELASTICSEARCH_URL).port || 443)")
    export TEST_ES_USERNAME="$CLOUD_DEPLOYMENT_USERNAME"
    export TEST_ES_PASSWORD="$CLOUD_DEPLOYMENT_PASSWORD"
    # Enabling ansi color output for Node.js again as we don't need to use it as a script interpreter anymore
    export FORCE_COLOR=1
    export TEST_BROWSER_HEADLESS=1
    # Error: attempted to use the "es" service to fetch Elasticsearch version info but the request failed: ConnectionError: self signed certificate in certificate chain
    export NODE_TLS_REJECT_UNAUTHORIZED=0
    echo "--- FTR - Reporting"
    node --no-warnings scripts/functional_test_runner.js --config x-pack/test/functional/apps/visualize/config.ts --include-tag=smoke --quiet

@tsullivan
Copy link
Member Author

@jbudz @mistic it is still not clear what is actionable for me to do with this PR. Is there something regarding the difference regarding where the test fails?

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] x-pack/test/alerting_api_integration/security_and_spaces/group1/config.ts / alerting api integration security and spaces enabled Alerts - Group 1 alerts backfill rule runs ad hoc backfill task should run all execution sets of a scheduled backfill and correctly generate alerts
  • [job] [logs] FTR Configs #41 / Serverless Common UI - Management Index Management Indices can delete index

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan marked this pull request as draft September 19, 2024 21:53
@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.15.1 v8.16.0
Projects
None yet
6 participants