Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suggestions to Console for keyword normalizers. #175054

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

a03nikki
Copy link
Contributor

@a03nikki a03nikki commented Jan 17, 2024

Summary

Add the missing Keyword normalizer to Console auto complete.

before screenshots Screenshot 2024-01-17 at 11 21 04 Screenshot 2024-01-17 at 11 20 18

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@a03nikki a03nikki added Feature:Console Dev Tools Console Feature Feature:Dev Tools Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Jan 17, 2024
@a03nikki a03nikki self-assigned this Jan 17, 2024
@a03nikki a03nikki requested a review from a team as a code owner January 17, 2024 17:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@a03nikki
Copy link
Contributor Author

@elasticmachine merge upstream

@a03nikki
Copy link
Contributor Author

a03nikki commented Feb 5, 2024

@elasticmachine merge upstream

@alisonelizabeth
Copy link
Contributor

@elasticmachine merge upstream

@alisonelizabeth alisonelizabeth added the release_note:skip Skip the PR/issue when compiling release notes label Sep 18, 2024
@alisonelizabeth
Copy link
Contributor

@elasticmachine

@alisonelizabeth
Copy link
Contributor

/ci

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @a03nikki

@alisonelizabeth alisonelizabeth merged commit 6f86d45 into main Sep 19, 2024
22 checks passed
@alisonelizabeth alisonelizabeth deleted the a03nikki-console-add-keyword-normalizer branch September 19, 2024 20:12
@kibanamachine kibanamachine added v9.0.0 backport:skip This commit does not require backporting labels Sep 19, 2024
@alisonelizabeth alisonelizabeth added backport:prev-minor Backport to the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting v9.0.0 labels Sep 19, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 19, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 19, 2024
…193483)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Add suggestions to Console for keyword normalizers.
(#175054)](#175054)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nicole
Albee","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-19T20:12:09Z","message":"Add
suggestions to Console for keyword normalizers.
(#175054)","sha":"6f86d45147bb68eb661ee1771efcf5c81646c654","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Feature:Dev
Tools","Team:Kibana
Management","release_note:skip","v9.0.0","backport:prev-minor"],"title":"Add
suggestions to Console for keyword
normalizers.","number":175054,"url":"#175054
suggestions to Console for keyword normalizers.
(#175054)","sha":"6f86d45147bb68eb661ee1771efcf5c81646c654"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"#175054
suggestions to Console for keyword normalizers.
(#175054)","sha":"6f86d45147bb68eb661ee1771efcf5c81646c654"}}]}]
BACKPORT-->

Co-authored-by: Nicole Albee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) Feature:Console Dev Tools Console Feature Feature:Dev Tools release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants