-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reporting] fix functional visualize app test #190016
base: main
Are you sure you want to change the base?
[Reporting] fix functional visualize app test #190016
Conversation
This reverts commit 7902ce7.
/ci |
Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6713 |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6713[✅] x-pack/test/functional/apps/visualize/config.ts: 42/42 tests passed. |
Seems this test is not flaky after all as it passes in the flaky test runner. However, I don't know why the main issue states there was an error of |
Pinging @elastic/appex-sharedux (Team:SharedUX) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tsullivan cherry-picked your changes into a branch on Kibana repo and run the pipeline on that branch. I'm not sure why but the pipeline still fails with those tests https://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4627#019138df-1849-462e-acec-063307e236aa
I think it's a good idea to open the PR with the unskip in a branch on Kibana repo so we can test more things on the pipeline itself.
At this point I'm not sure what could cause those failres. @jbudz maybe do you have any idea?
This test is running against a cloud deployment. Did we verify it runs there?
Pipelines can run against pull requests, set the branch to |
^^ @mistic |
@jbudz I had that impression and tried it at https://buildkite.com/elastic/kibana-artifacts-snapshot/builds?branch=pull%2F190016...but now I know why it didn't work..I forgot about the last For the record, I just started a new build based on the changes on this PR https://buildkite.com/elastic/kibana-artifacts-snapshot/builds/4629 |
I haven't looked at it. Does this need help? |
|
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Summary
Unskip functional test. Closes #189590