Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #4361) Change CA generation in tests to avoid using SHA1 #4399

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 30, 2025

What is the problem this PR solves?

Tests ran with GODEBUG=fips140=only will panic due to CA SubjectKeyId generation using SHA1 by default.

How does this PR solve the problem?

Populate SubjectKeyId with value generated by other algorithm; copied implementation from elastic/elastic-agent-libs#263

How to test this PR locally

GODEBUG=fips140=only gotip test ./...

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
    This is an automatic backport of pull request Change CA generation in tests to avoid using SHA1 #4361 done by Mergify.

@mergify mergify bot requested a review from a team as a code owner January 30, 2025 18:17
@mergify mergify bot added the backport label Jan 30, 2025
@michel-laterman
Copy link
Contributor

buildkite test this

@michel-laterman michel-laterman enabled auto-merge (squash) January 30, 2025 23:01
@pkoutsovasilis
Copy link

buildkite test this

Copy link
Contributor Author

mergify bot commented Feb 3, 2025

This pull request has not been merged yet. Could you please review and merge it @michel-laterman? 🙏

@michel-laterman
Copy link
Contributor

buildkite test this

@michel-laterman
Copy link
Contributor

Current e2e failure is because the fleet-server & ES versions do not match: failed version compatibility check with elasticsearch (Agent: 8.19.0-SNAPSHOT, Elasticsearch: 8.18.0): unsupported version","ecs.version":"1.6.0"}

@simitt
Copy link

simitt commented Feb 5, 2025

Current e2e failure is because the fleet-server & ES versions do not match: failed version compatibility check with elasticsearch (Agent: 8.19.0-SNAPSHOT, Elasticsearch: 8.18.0): unsupported version","ecs.version":"1.6.0"}

@michel-laterman how is this going to be fixed?

@michel-laterman
Copy link
Contributor

I think #4371 needs to update the stack to the newer version

Copy link
Contributor Author

mergify bot commented Feb 10, 2025

This pull request has not been merged yet. Could you please review and merge it @michel-laterman? 🙏

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Feb 10, 2025
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@michel-laterman michel-laterman merged commit 4d9d3df into 8.x Feb 10, 2025
9 checks passed
@michel-laterman michel-laterman deleted the mergify/bp/8.x/pr-4361 branch February 10, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants