-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ebpf test runner #208
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasberlin
approved these changes
Sep 25, 2024
haesbaert
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made three small suggestions, basically whitespace.
I was able to run the tests, but it took me awhile to figure why it wasn't working initially, I had a /tmp/foo already in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to run tests
This completely refactors the go testrunner for EventsTrace. This has a number of advantages:
make testbins
target for the c test binariesThis also fixes a few known bugs, and probably many more:
In addition, I fixed a few bugs in the tests that I ran into while refactoring:
\x
, which is not a valid JSON escape character and broke all the JSON parsers I tried.How to run tests
Known issues with individual tests:
fork_exec.c
works by setting the capabilities mask to an identifiable but meaningless mask value; for whatever reason this works in the test environment, but on my machine the new capability set completely breaks the binary.create_rename_delete_file_container.c
breaks on newer kernels if you try to remove the directories before doing an unmount onovl_mountpoint
, but on the mainline tests, and only the mainline tests (which are actually kind of old), this unmount operation fails with an Invalid Argument error.