-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: [POC] Refactor: port unittest to pytest #3361
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Port seems fine. Checked out branch, ran tests collectively and then individually and they worked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ports look good! Tests work locally.
FWIW, I manually compared the time it took to run the unit tests with other PRs and the time to complete has not changed. |
Converted to draft so it doesnt accidentally get merged. |
Issues
Related to https://github.com/elastic/ia-trade-team/issues/238
Sets up some foundational changes that we plan to make to support Detections as Code. We want to be able to use more useful features of
pytest
and the current setup of intermingling pythonunittest
while we actually already usepytest
complicated our ability to do this. Migrating to a single testing capability removes some of this confusion and sets us up for the next enhancements to come.Summary
TestPackages::test_rule_versioning
where we weren't actually iterating over the rules.Testing
Unit tests should all still pass as before.