feat(ebounty.lic): v1.7.0 add BOOST BOUNTY type selection

[mrhoribu]

Important

Adds boost_type selection for bounty boosts in ebounty.lic, updating UI and logic to handle new option.

• Behavior:
  • Adds boost_type option to select specific bounty type when boost is active in ebounty.lic.
  • Updates bounty_get in Task module to include boost_type in bounty request if boost is active.
• UI:
  • Adds GtkComboBoxText for boost_type selection in the setup UI.
  • Updates load_settings and on_update to handle boost_type changes.
• Data:
  • Adds boost_type to Data class attributes and initializes it in initialize().
  • Updates @@categories in Setup to include boost_type with default value.

^{This description was created by for 166aec2. You can customize this summary. It will automatically update as commits are pushed.}

[mrhoribu]

@ellipsis remove previous comments and review again

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to 166aec2 in 1 minute and 33 seconds. Click for details.

• Reviewed 155 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 10 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. ebounty.lic:2188

• Draft comment:
  Task.bounty_check recursively calls itself, which may cause stack overflow; restructure as a loop or use a scheduler.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

2. ebounty.lic:2503

• Draft comment:
  Multiple hard-coded identifiers and magic numbers (e.g. NPC UIDs, spell IDs) are scattered throughout; use named constants for better maintainability.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

3. ebounty.lic:3240

• Draft comment:
  Chained gsub calls for normalizing skin names are brittle; consider a helper function or mapping table.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

4. ebounty.lic:2329

• Draft comment:
  Loops waiting for NPC responses (e.g., in ask_guard) lack clear timeout or error handling, risking indefinite blocking.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

5. ebounty.lic:2800

• Draft comment:
  Heavy use of sleep and blocking calls without timeout conditions can lead to hangs; ensure failure cases are handled.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

6. ebounty.lic:1655

• Draft comment:
  The script is monolithic with deeply nested logic; refactor into smaller, modular methods to enhance readability and future maintenance.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

7. ebounty.lic:1245

• Draft comment:
  Numerous regular expressions match game text; centralize and document these patterns to handle potential changes in game messages.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

8. ebounty.lic:3327

• Draft comment:
  Global state (e.g., EBounty.data, UserVars.op) is modified in many places; consider encapsulating state changes to avoid unintended side effects.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

9. scripts/ebounty.lic:1275

• Draft comment:
  Typographical note: the label text "Rest when mind full" might be intended to be "Rest when mindful". Please review if this is the desired wording.
• Reason this comment was not posted:
  Comment was on unchanged code.

10. scripts/ebounty.lic:2512

• Draft comment:
  There is a double space between 'matter.' and 'Go report' which might be an unintended typographical error. Consider reducing it to a single space.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_ijM0yPT9FzbxezEF

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}