fix(bigshot.lic): v5.9.5 various updates

[mrhoribu]

Important

Update bigshot.lic to version 5.9.5 with improvements including removal of companion_check, addition of check_disks parameter, and coupdegrace buff check.

• Behavior:
  • Remove companion_check calls as they are no longer needed with GameObj.targets.
  • Add check_disks parameter to bigclaim? method.
  • Add claim check to attack_break and need_to_loot? (ignoring disk check).
  • Add coupdegrace buff check and command check.
  • Increase bs_move timeout from 2 to 5 seconds.
• Version:
  • Update version to 5.9.5 in bigshot.lic.

^{This description was created by for 138c564. You can customize this summary. It will automatically update as commits are pushed.}

[mrhoribu]

@ellipsis remove previous comments and review again

[ellipsis-dev]

Caution

Changes requested ❌

Reviewed everything up to 138c564 in 3 minutes and 33 seconds. Click for details.

• Reviewed 139 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 13 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. scripts/bigshot.lic:3011

• Draft comment:
  Regex updated: 'coupdegrace' added. Confirm that its inclusion and the overall regex performance and capture behavior are as intended.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

2. scripts/bigshot.lic:3045

• Draft comment:
  Buff check for 'coupdegrace' uses a regex with Effects::Buffs.time_left. Ensure that the API supports regex patterns and that the matched buff string consistently follows the pattern.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

3. scripts/bigshot.lic:3079

• Draft comment:
  New lambda for 'coupdegrace' in the second check uses Effects::Buffs.active? with a regex. Verify this behaves consistently with other buff checks.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

4. scripts/bigshot.lic:5142

• Draft comment:
  Added the 'check_disks' parameter to bigclaim?. Ensure that all call sites and intended behaviors are updated accordingly.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

5. scripts/bigshot.lic:5150

• Draft comment:
  Updated disk check logic: using '!check_disks' in the condition. Review the combined condition to ensure it correctly bypasses the disk check when intended and that edge cases are covered.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

6. scripts/bigshot.lic:5197

• Draft comment:
  Companion_check() call has been commented out. Confirm that its removal (and reliance on GameObj.targets) does not leave gaps in companion validation logic.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

7. scripts/bigshot.lic:5729

• Draft comment:
  In attack_break, a new 'No Claim' condition is added using bigclaim?(check_disks: false). Verify that bypassing the disk check in this context is deliberate and doesn’t affect overall claim validation.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

8. scripts/bigshot.lic:5792

• Draft comment:
  In need_to_loot?, the immediate return unless bigclaim?(check_disks: false) now affects loot logic. Confirm that omitting disk checks here is intended.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

9. scripts/bigshot.lic:6697

• Draft comment:
  Move timeout increased from 2 to 5 seconds, but the inline comment still references a 2-second timeout. Update the comment to accurately reflect the new timeout.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

10. scripts/bigshot.lic:7256

• Draft comment:
  Companion_check() call is commented out in the tail/follow/link branch. Verify that removal here aligns with overall companion validation strategy.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

11. scripts/bigshot.lic:24

• Draft comment:
  Typographical: The term 'coupdegrace' appears; consider using the standard spelling 'coup de grace' for clarity.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

12. scripts/bigshot.lic:3020

• Draft comment:
  On line 3020, please check the term “coupdegrace”. In common usage it’s often written as "coup de grace" (with a space) or even with an accent. If the current spelling is intentional for command matching, perhaps consider adding a comment for clarity.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% 1. The term is used in a command matching regex pattern 2. The current spelling is clearly intentional for command matching purposes 3. The code already has many other similar command patterns that use simplified spellings 4. The suggestion to add a comment would add noise to an already long regex pattern 5. The spelling is consistent throughout the file The comment raises a valid point about non-standard spelling, but may not fully appreciate the technical constraints of command matching. While technically correct about spelling, the simplified spelling is intentional and necessary for command matching. Adding a comment would add unnecessary noise. Delete the comment. The spelling is intentionally simplified for command matching purposes, and adding a comment would not improve code clarity.

13. scripts/bigshot.lic:5745

• Draft comment:
  Typographical inconsistency: the key "Should rest" (with a lowercase 'r') does not match the capitalization style used in the other conditions (e.g., "Should Rest"). Please adjust for consistent capitalization.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_QLsuNz9U3gs7aw9h

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}