feat(elogin.lic): v2.0.0 for Lich 5.12+ yaml support

[OSXLich-Doug]

This proposal for a new elogin comes with some particulars. Please check 'other scripts' channel for details and helpful hints.

---

Important

Introduces a new elogin script for Lich 5+ with enhanced login capabilities, supporting YAML and DAT backends, and refactored command handling.

• Behavior:
  • New elogin script for Lich 5+ with enhanced login capabilities using LoginHelpers.
  • Supports YAML and DAT backends for character entry data.
  • Commands: set realm, add, modify, delete, list, and login with optional scripts.
• Helper Methods:
  • Added lich_version_at_least?, debug_log, handle_error, log_operation, load_entry_data, save_entry_data, and others for internal operations.
  • resolve_login_helpers_paths and ensure_login_helpers_loaded manage LoginHelpers loading.
• Main Execution:
  • Parses command-line arguments and executes corresponding actions.
  • Handles errors and logs operations throughout the script.

^{This description was created by for c08f480. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Caution

Changes requested ❌

Reviewed everything up to c08f480 in 2 minutes and 21 seconds. Click for details.

• Reviewed 742 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 3 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. scripts/elogin.lic:337

• Draft comment:
  The argument normalization using 'args.shift' may be brittle. Add a comment explaining its intent (e.g. handling duplicate arguments) to aid future maintenance.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

2. scripts/elogin.lic:480

• Draft comment:
  The fallback using char_entry[:_requested_game_code] might be risky if that key isn’t set in all scenarios. Ensure that this key is consistently provided in all expected data formats.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to ensure that a key is consistently provided, which violates the rule against asking the author to ensure behavior. It doesn't provide a specific suggestion or ask for a test to be written.

3. scripts/elogin.lic:214

• Draft comment:
  Storing passwords in plain text (e.g. in the entry data) poses a security risk. Consider using encryption or another secure storage method if feasible.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50% While the security concern is valid, this appears to be a fundamental design choice of the login system. The passwords need to be stored in a way that allows them to be used for automated login. Changing this would require a major architectural change to the entire login system, not just this file. The comment doesn't provide specific actionable guidance on how to implement encryption while maintaining functionality. The security concern is legitimate and important. Storing passwords in plain text is generally considered bad practice. However, this is a local client-side script where the passwords are already stored by the game client. The scope for improving security is limited without breaking core functionality. The comment should be deleted as it raises a valid but non-actionable concern that would require fundamental changes to the login system architecture.

Workflow ID: wflow_zdTNRWmVTh3ra57C

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}