FEAT(efamgo2.lic): v1.0.0 - Fork and update of famgo2.lic

[AndreasWelch]

Forks famgo2.lic for code updates and support of real room ids (uid).

---

Important

Forks famgo2.lic to create efamgo2.lic, adding support for real room IDs and guiding familiars/eyes to specified rooms with error handling and pathfinding.

• Behavior:
  • Forks famgo2.lic to create efamgo2.lic with support for real room IDs (u#####).
  • Guides familiar/eye to a specified room, handling both Lich and real room numbers.
  • Pauses for special procedures, requiring user intervention to continue.
  • Exits with error messages if destination or start room is unknown or if pathfinding fails.
• Pathfinding:
  • Uses Dijkstra's algorithm for pathfinding between rooms.
  • Handles movement commands for familiar/eye based on room connections.
• Misc:
  • Initial release version 1.0.0.

^{This description was created by for b8ed88f. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Caution

Changes requested ❌

Reviewed everything up to b8ed88f in 2 minutes and 51 seconds. Click for details.

• Reviewed 129 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 6 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. scripts/efamgo2.lic:77

• Draft comment:
  Undefined variable 'variable[1]': likely meant Script.current.vars[1].
• Reason this comment was not posted:
  Marked as duplicate.

2. scripts/efamgo2.lic:46

• Draft comment:
  Inconsistent variable usage: use Script.current.vars[1] instead of script.vars[1].
• Reason this comment was not posted:
  Marked as duplicate.

3. scripts/efamgo2.lic:10

• Draft comment:
  Typo alert: In the comment on line 10, 'what to tell you pet' should be corrected to 'what to tell your pet'.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% While the typo fix is technically correct, our rules state we should not make purely informative comments. This is a minor typo in documentation that doesn't affect functionality. The meaning is still clear even with the typo. Documentation typos are not critical enough to warrant a comment unless they significantly impact understanding. The typo could potentially confuse users reading the documentation. Documentation quality is important for usability. While documentation quality matters, this particular typo is minor and the meaning remains clear. The cost of the review comment outweighs the small benefit of fixing this typo. Delete this comment as it points out a minor documentation typo that doesn't significantly impact understanding of the code or documentation.

4. scripts/efamgo2.lic:69

• Draft comment:
  Typo alert: The comment on line 69 contains the phrase 'go where your are'. Consider changing it to 'go where you are'.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% While the comment correctly identifies a grammatical error, it's a very minor issue in a code comment that doesn't affect functionality. Comments are documentation, so clarity is important, but this is an extremely minor fix that doesn't significantly impact readability or understanding. The grammatical error could potentially cause slight confusion for non-native English speakers. Documentation quality does matter. While documentation quality matters, this is such a minor grammatical issue that most readers would naturally read it correctly anyway. The meaning is still clear despite the typo. This comment should be deleted as it addresses an extremely minor documentation issue that doesn't impact code functionality or significantly affect readability.

5. scripts/efamgo2.lic:46

• Draft comment:
  Typographical inconsistency: In line 46, 'Room[script.vars[1]]' uses 'script.vars' whereas elsewhere 'Script.current.vars[1]' is used. Consider unifying the variable reference for consistency.
• Reason this comment was not posted:
  Marked as duplicate.

6. scripts/efamgo2.lic:77

• Draft comment:
  Typographical inconsistency: In line 77, 'variable[1]' is used as an argument to Map.dijkstra. This seems inconsistent with the usage of 'Script.current.vars[1]' elsewhere. Please consider correcting the variable name for consistency.
• Reason this comment was not posted:
  Marked as duplicate.

Workflow ID: wflow_fbFD9hwjvJcQ8fep

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[mrhoribu]

Should be included inside of a method that is called outside of the of module

module Name
  # module contents
  def self.do_something
    # method contents
  end
end

if Script.current.vars[1] =~ /^u?[0-9]+$/
  Name.do_something
else
  Lich::Messaging.mono("usage: #{$lich_char}#{Script.current.name} <room number>")
  exit
end