Skip to content

Conversation

mrhoribu
Copy link
Contributor

@mrhoribu mrhoribu commented Aug 16, 2025

Important

Fixes missing space in StowListContainer regex in xmlparser.rb for correct stow list parsing.

  • Regex Fix:
    • Corrects StowListContainer regex in xmlparser.rb by adding a missing space before the parenthesis to ensure proper parsing of stow list containers.

This description was created by Ellipsis for 7081333. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 7081333 in 30 seconds. Click for details.
  • Reviewed 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. lib/gemstone/infomon/xmlparser.rb:85
  • Draft comment:
    Added missing literal space before '(' in the regex capture group. Verify that the output now correctly includes a space before the container type.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 50% <= threshold 50% The comment is pointing out a change in a regex pattern, specifically the addition of a space before a parenthesis in a capture group. The second part of the comment asks the author to verify the output, which violates the rule against asking the author to verify or ensure behavior. However, the first part of the comment is informative and could be useful to highlight the change made.

Workflow ID: wflow_V4I5QMXgYhvcrg1a

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@mrhoribu mrhoribu merged commit 88a880a into staging Sep 6, 2025
5 checks passed
@mrhoribu mrhoribu deleted the fix/xmlparser.rb-infomon-stowlist branch September 6, 2025 15:28
mrhoribu added a commit that referenced this pull request Sep 8, 2025
fix(all): update.rb word boundary for abbreviations #971

fix(dr): equipmanager.rb Fix for changed game output. #969
fix(dr): common-arcana.rb Regalia fix for changed game output. #970
fix(dr): common-items.rb Fix for changed inventory command output #973

fix(gs): StowList missing space in capture in xmlparser.rb #963
fix(gs): stowlist.rb wait for RT when issuing check #964
fix(gs): readylist.rb wait for RT when issuing check #965
fix(gs): Bounty heirloom return msg'ing update #972

<!-- ELLIPSIS_HIDDEN -->


----

> [!IMPORTANT]
> Prepare for 5.12.5 release with version updates and various game
output fixes.
> 
>   - **Version Update**:
> - Update `MyAppVersion` in `R4LGTK3.iss` and `LICH_VERSION` in
`lib/version.rb` to `5.12.5`.
>     - Update `AppId` in `R4LGTK3.iss`.
>   - **Fixes**:
>     - Update word boundary for abbreviations in `update.rb`.
> - Fix game output handling in `equipmanager.rb`, `common-arcana.rb`,
and `common-items.rb` for DragonRealms.
> - Fix missing space in `StowList` capture in `xmlparser.rb` for
GemStone.
> - Add wait for RT in `stowlist.rb` and `readylist.rb` for GemStone.
> - Update Bounty heirloom return messaging in `readylist.rb` for
GemStone.
> 
> <sup>This description was created by </sup>[<img alt="Ellipsis"
src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=elanthia-online%2Flich-5&utm_source=github&utm_medium=referral)<sup>
for f97f136. You can
[customize](https://app.ellipsis.dev/elanthia-online/settings/summaries)
this summary. It will automatically update as commits are pushed.</sup>


<!-- ELLIPSIS_HIDDEN -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants